Re: Enhancements to git-protocoll
- From
Fredrik Gustafsson <iveqy@iveqy.com>
- Date
- Jul 29, 2012, 15:41 UTC
- Message-ID
- <20120729154124.GA19201@paksenarrion.iveqy.com>
- In-Reply-To
- <CAMK1S_hHBB9BViH=CFuJNgMJzMtzhE0mGc7ryFaDWNxOoH2Pgg@mail.gmail.com>
On Sun, Jul 29, 2012 at 08:45:39PM +0530, Sitaram Chamarty wrote:
> I think you misunderstood how gitolite works. Gitolite does not have > *any* user interaction other than sending some extra messages back via > STDERR if you're using a normal git client to do normal git operations > (clone/fetch/ls-remote).
As you say, gitolite has userinteraction, and its not even standard to git error messages. Try cloning a repo that doesn't exists via gitolite and a regular ssh connection:
[iveqy@paksenarrion git]$ git clone ssh://gitolite@localhost/testing2 Cloning into testing2... FATAL: R any testing2 id_rsa DENIED by fallthru (or you mis-spelled the reponame) fatal: The remote end hung up unexpectedly [iveqy@paksenarrion git]$ git clone ssh://iveqy@localhost/testing2 Cloning into testing... fatal: '/testing2' does not appear to be a git repository fatal: The remote end hung up unexpectedly
> Such messages are *no different* from something that an update or > pre-receive hook might send back even on a normal (no gitolite) git > server.
As I showed above the "non-existing" repo is a case when it's different. But you have a good point in hooks, of course a hook also should be able to have two way user interaction.
Show 5 quoted lines
> The only time that gitolite might have any user *interaction* is when > using "gitolite commands". These do not run git at all (neither on > the client nor on the server), and in fact merely provide a convenient > way to allow users to run a controlled set of specific *shell* > commands.
I do understand how gitolite works. However this is off-topic to my original question. I also do not have an oppinion on how gitolite should work, I simply don't care. Gitolite is an widely acceptet git tool, I see improvement opportunities in git to allow an other program to utilize two-way user interaction all the time, this will not effect gitolite at all.
So in my point of view, it's up to Junio if I shall continue explore this path and maybe find a way of doing this in git, "the right way". Or if this is something unwanted and gitolite and alike programs should continue with STDERR "hacks".
-- Med vänliga hälsningar Fredrik Gustafsson tel: 0733-608274 e-post: iveqy@iveqy.com