[PATCH 2/6] t7502: properly quote GIT_EDITOR
- From
Jeff King <peff@peff.net>
- Date
- Jul 26, 2012, 20:28 UTC
- Message-ID
- <20120726202759.GB16048@sigill.intra.peff.net>
- In-Reply-To
- <20120726202644.GA15043@sigill.intra.peff.net>
One of the tests tries to ensure that editor is not run due to an early failure. However, it needs to quote the pathname of the trash directory used in $GIT_EDITOR, since git will pass it along to the shell. In other words, the test would pass whether the code was correct or not, since the unquoted editor specification would never run.
We never noticed the problem because the code is indeed correct, so git-commit never even tried to run the editor.
Signed-off-by: Jeff King <peff@peff.net> --- t/t7502-commit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh index ddce53a..3f9fb55 100755 --- a/t/t7502-commit.sh +++ b/t/t7502-commit.sh @@ -290,7 +290,7 @@ test_expect_success 'do not fire editor in the presence of conflicts' ' test_must_fail git cherry-pick -n master && echo "editor not started" >.git/result && ( - GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" && + GIT_EDITOR="\"$(pwd)/.git/FAKE_EDITOR\"" && export GIT_EDITOR && test_must_fail git commit ) &&
-- 1.7.11.3.8.ge78f547