Re: [RFC 01/16] Implement a remote helper for svn in C.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 26, 2012, 07:46 UTC
Message-ID: <20120726074607.GA4455@burratino>
In-Reply-To: <1343287957-22040-2-git-send-email-florian.achleitner.2.6.31@gmail.com>

Hi,

Florian Achleitner wrote:

Show 16 quoted lines

> --- /dev/null
> +++ b/contrib/svn-fe/remote-svn.c
> @@ -0,0 +1,219 @@
> +
> +#include "cache.h"
> +#include "remote.h"
> +#include "strbuf.h"
> +#include "url.h"
> +#include "exec_cmd.h"
> +#include "run-command.h"
> +#include "svndump.h"
> +#include "argv-array.h"
> +
> +static int debug;
> +
> +static inline void printd(const char *fmt, ...)

I remember reviewing this before, and mentioning that this could be replaced with trace_printf() and that would simplify some code and improve the functionality. I think I also remember giving some other suggestions, but I don't have it in front of me so I can't be sure (should have more time this weekend).

Did you look over that review? Did you have any questions about it, or was it just full of bad ideas, or something else?

It's silly and vain of me, but I'm not motivated by the idea of spending more time looking over this without anything coming of it. (Rejecting suggestions is fine, but sending feedback when doing so is important because otherwise reviewers get demotivated.)

Hope that helps, Jonathan