git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN.

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jul 26, 2012, 00:26 UTC
Message-ID
<20120726002612.GA3038@burratino>
In-Reply-To
<501088EC.50405@pobox.com>
Michael G Schwern wrote:
> This is rapidly getting into the weeds.  Regardless of the debate below, what
> would you like me to do?  Switch indentation to tabs and resubmit?  AFAIK only
> the new tests are affected.

Yes, please do so at some point before the final submission. (If there's more feedback coming for this generation of the patches, no need to resubmit right away unless you want to. In general, when getting review a useful strategy can be to discuss proposed changes and batch them until the discussion seems to have died down and only then resubmit the next version.)

If we want to switch indentation styles (not a traditional way to start working with an existing project, but whatever), that would be a separate change, affecting all the code consistently.

Thanks, Jonathan

Previous: Eric WongNext: Michael G. Schwern
Message 8 of 12 in “Move Git::SVN into its own .pm file”
  1. Michael G. SchwernJul 25, 2012
  2. 1/4 Extract some utilities from git-svn to allow extracting Git::SVN.Michael G. Schwern, Jul 25, 2012
  3. Eric WongJul 25, 2012
  4. Michael G SchwernJul 25, 2012
  5. Eric WongJul 25, 2012
  6. Michael G SchwernJul 26, 2012
  7. Eric WongJul 26, 2012
  8. Jonathan NiederJul 26, 2012
  9. 2/4 Prepare Git::SVN for extraction into its own file.Michael G. Schwern, Jul 25, 2012
  10. 4/4 Move initialization of Git::SVN variables into Git::SVN.Michael G. Schwern, Jul 25, 2012
  11. Jonathan NiederJul 25, 2012
  12. Michael G SchwernJul 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.