Re: [RFC/PATCH] t3300-*.sh: Fix a TAP parse error

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 24, 2012, 19:21 UTC
Message-ID: <20120724192103.GB5210@burratino>
In-Reply-To: <500EEAAA.8030604@ramsay1.demon.co.uk>

Hi,

Ramsay Jones wrote:

> The only problematic platforms I test on are "NTFS/bash" on cygwin and MinGW.
> Since commit 2b843732 ("Suppress some bash redirection error messages",
> 26-08-2008), I have not noticed any complaints regarding this problem.

Yeah, that probably took care of squashing the messages. Maybe my memory is too long. ;-)

[...]

Show 18 quoted lines

> No, I don't think this would be a good direction to go in. This may
> not be a good idea either, but if you wanted to add a check here, then
> maybe something like this (totally untested):
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index acda33d..53a2422 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -354,6 +354,9 @@ test_done () {
>  	case "$test_failure" in
>  	0)
>  		# Maybe print SKIP message
> +		if test -n "$skip_all" && test $test_count -gt 0; then
> +			error "Can't use skip_all after running some tests"
> +		fi
>  		[ -z "$skip_all" ] || skip_all=" # SKIP $skip_all"
>  
>  		if test $test_external_has_tap -eq 0; then

I think preventing invalid TAP output like this would be a very good thing! As a start, this patchlet looks good to me, and then I guess we'll have to think more about what happens when a person wants to skip_all_remaining after a test has already been run.

Care to format it as a "git am"-able patch, or should I?

Thanks again, Jonathan