Re: [PATCH] fast-import: catch deletion of non-existent file in input

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 15, 2012, 18:11 UTC
Message-ID: <20120715181151.GA1986@burratino>
In-Reply-To: <20120715102300.GA28667@sigill.intra.peff.net>

Hi,

Jeff King wrote:

> Subject: fast-import: catch deletion of non-existent file in input

[...]

> We silently ignored the bogus "D foo" directive, and the
> resulting tree incorrectly contained "bar". With this patch,
> we notice the bogus input and die.

This breaks svn-fe, which relies on the existing semantics when asked to copy an empty directory.

That's my fault because we never check that in the testsuite, but I also wouldn't be surprised if other importers were relying on the same thing.

Any API break this big without a justification along the lines

	We can be confident that no existing importer uses this
	construct because ...

_needs_ to be guarded by a new "feature" to be safe for existing importers.

Let's repeat that for emphasis: API breaks in fast-import not guarded with a new "feature" type are not ok.

Sorry, Jonathan