Re: [BUG] serious inflate inconsistency on master

From: Jeff King <peff@peff.net>
Date: Jul 4, 2012, 07:24 UTC
Message-ID: <20120704072412.GC24807@sigill.intra.peff.net>
In-Reply-To: <CACsJy8AH6HHxE-P4j4O_VtVzz6-pe2VWk5ZayOfbZomfX2z7sg@mail.gmail.com>

On Wed, Jul 04, 2012 at 02:01:06PM +0700, Nguyen Thai Ngoc Duy wrote:

Show 14 quoted lines

> On Wed, Jul 4, 2012 at 1:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
> >
> >> By the way I searched the commit that introduces that check with "git
> >> log --follow -p builtin/index-pack.c" but I could not find it. What
> >> did I do wrong?
> >
> > Your commit 8a2e163cc shows changes to the file at ll.535-540; these
> > come from 776ea370 builtin-index-pack.c ll.383-388.
> >
> >   $ git show 776ea370:builtin-index-pack.c
> 
> git newbie's hat's on. How do you find 776ea370, git-blame? Another
> question is why doesn't git-log show that commit?

I used git-blame to find it. As to your second question, I believe it is one of the side-effects of the way --follow is bolted onto the revision traversal. Look at:

  gitk -- builtin/index-pack.c builtin-index-pack.c

and you will see that the commit in question happened on a simultaneous branch with the big builtin rename commit. Since we process 776ea370 before we hit the rename commit, we do not yet realize that builtin-index-pack.c is of interest to us.

-Peff