Re: [PATCH] add test case for rebase of empty commit

From: Neil Horman <nhorman@tuxdriver.com>
Date: Jul 3, 2012, 23:40 UTC
Message-ID: <20120703234048.GA10224@neilslaptop.think-freely.org>
In-Reply-To: <7vpq8ctune.fsf@alter.siamese.dyndns.org>

On Tue, Jul 03, 2012 at 02:13:57PM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> Neil Horman <nhorman@tuxdriver.com> writes:
> 
> > On Tue, Jul 03, 2012 at 12:00:27PM -0700, Junio C Hamano wrote:
> >> 
> >> The changelog might be similar or textually identical, but it is
> >> entirely a different matter if it makes sense taken out of the
> >> context (i.e. cherry-picked).  So I would personally do not bother
> >> "filtering" about them too much---if you ask for empties, you will
> >> get all empties.
> >> 
> > Ok, copy that.
> 
> That was somewhat unexpected, though ;-) It was 30% tongue-in-cheek
> comment.  People who want to keep the empty commits in the history
> may want some filtering. As I am not among them, I do not think of
> anything useful (other than "filter all empty ones away", that is).
> 
>

I understand what you're saying (for the record, I'm ok with the duplicates, to be fixed up at a later date, as opposed to dropping them all). But the fact remains, theres not obvious differentiator, other than some fuzzy search on the changelog we can use to differentiate empty commits. Let me think about it some more, maybe theres some sort of policy specification we can make regarding the changelog that would let us intellegently filter empty commits appropriately. Best Neil