Re: [PATCH/RFC] compat/terminal: support echoing on windows

From: Jeff King <peff@peff.net>
Date: Jun 27, 2012, 21:08 UTC
Message-ID: <20120627210810.GC2292@sigill.intra.peff.net>
In-Reply-To: <1340544903-37016-1-git-send-email-kusmabite@gmail.com>

On Sun, Jun 24, 2012 at 03:35:03PM +0200, Erik Faye-Lund wrote:

Show 8 quoted lines

> Without /dev/tty support, git_terminal_prompt simply ignores the
> 'echo'-parameter. On Windows we can do better by clevering up our
> getpass-implementation a bit so it can conditionally echo.
> 
> While we're at it, plug a small memory-leak by returning a pointer
> to a static strbuf instead of detaching it. This is the same thing
> the /dev/tty-version of git_terminal_prompt does, and the callee
> doesn't expect to have to free it's memory.

Very nice. I was hoping for something exactly like this when I wrote the original git_terminal_prompt patch.

-Peff

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en