Re: git-p4: Jobs and skipSubmitEdit

From: Pete Wyckoff <pw@padd.com>
Date: Jun 24, 2012, 20:24 UTC
Message-ID: <20120624202445.GA27664@padd.com>
In-Reply-To: <CAFLRbop2aETNp0-6AdvSTx7Jmh7epYZ6rQc6hhFHbxZrGdEo9g@mail.gmail.com>

mike@horowitz.name wrote on Fri, 22 Jun 2012 12:15 -0400:

Show 16 quoted lines

> I've written a git prepare-commit-msg hook to do what the Perforce
> JobsView would essentially do, so I can include the jobs directly in
> my git commit message, and then use git-p4.skipSubmitEdit=true, so I
> can just push things into Perforce directly from git without ever
> being prompted by Perforce.
> 
> Problem is that this doesn't work, because git-p4 tabs in the entire
> commit message to put it in the "Description:" section of the Perforce
> changelist, and my "Jobs:" ends up tabbed in, and it it required by
> Perforce to be at the beginning of the line.  The submit ends up
> failing, because "Jobs:" is required.  I am forced to turn off
> skipSubmitEdit and edit the message to remove the tab from the "Jobs:"
> line each commit.
> 
> Is there any option to make this work right, or does the git-p4 not
> support this?

This is a great idea, and something I've thought would be useful too. There's no code to handle it currently, but it shouldn't be too hard.

I'm imagining that special strings in the git commit are hoisted up out of the description when building the p4 change message, as you describe. Are there any more than "Jobs:"? Is it just a single instance that might appear?

An easy way to do this is to change prepareLogMessage to alter or add a Jobs line. Unless we decide this needs to be more general.

		-- Pete