[PATCH 2/1] perl/Makefile.PL: warn about duplicate module list in perl/Makefile
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 15, 2012, 18:14 UTC
- Message-ID
- <20120615181446.GI10752@burratino>
- In-Reply-To
- <20120615180505.GH10752@burratino>
Adding or removing a module requires modifying both files to support builds with and without MakeMaker. Add a comment to remind patch authors and reviewers at the crucial moment.
Longer term, it would be nicer to maintain a single list, perhaps in a separate file used by both build systems.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- perl/Makefile.PL | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/perl/Makefile.PL b/perl/Makefile.PL index 2c20290f..b54b04a6 100644 --- a/perl/Makefile.PL +++ b/perl/Makefile.PL @@ -24,6 +24,10 @@ endif MAKE_FRAG } +# XXX. When editing this list: +# +# * Please update perl/Makefile, too. +# * Don't forget to test with NO_PERL_MAKEMAKER=YesPlease my %pm = ( 'Git.pm' => '$(INST_LIBDIR)/Git.pm', 'Git/I18N.pm' => '$(INST_LIBDIR)/Git/I18N.pm',
-- 1.7.10.4