git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: rebase when an author uses accents in name on MacOSx

From
Jeff King <peff@peff.net>
Date
Jun 2, 2012, 16:09 UTC
Message-ID
<20120602160904.GB15017@sigill.intra.peff.net>
In-Reply-To
<B0BB0BD8-EFB5-4A3C-A6F7-00A1C7DE0509@spotinfluence.com>
On Fri, Jun 01, 2012 at 08:56:01AM -0500, Lanny Ripple wrote:
> I did show that sed was broken and have provided a minimal, reproducible test.
> 
> I have reported it to the sed maintainers and they are working on it.
Great. Do we know yet which versions are affected?
Show 10 quoted lines
> A message or comment in the code that seds not properly handling utf8
> characters have been shown to be the cause of the problem and that git
> selects sed from the PATH would have been 100% effective in at least
> one case.  I don't know the troubleshooting skills of the other two
> people that bumped into the problem so can't comment.  Of the billions
> of people that have not (if it existed) looked at the breadcrumb and
> weren't led astray it's (would have) also been 100% effective.  Can
> you in turn posit any reasonable way that get_author_ident_from_commit
> would improperly build author-script short of a bad sed?  I guess you
> could pull out transient or systematic disk error.

I assume from bogus commit objects. But I admit I am just guessing, and don't have data.

Show 6 quoted lines
> You do, in fact, have several solutions.  I won't reiterate since they
> are in the thread earlier.  You also have in many cases the valid
> concern that the solutions would not be backwards compatible.  And
> yes, this sed will get fixed but what then?  The next person that gets
> a sed they don't expect earlier in their PATH will have to go through
> the same steps.
When I said:
> > But really, I'd rather just see the broken sed fixed. Where would the
> > breadcrumb lead people at this point, anyway? We don't actually have a
> > solution besides "uninstall this other, crappy sed". Has the sed bug
> > actually been fixed?

I meant that there is not a fix for the _user_ to perform at that point. The point of a breadcrumb like that is that we are not going to put a fix into git, so we want to at least give the user a clue that their system has a problem. But what is their next step after being informed that their system has a problem?

-Peff
Previous: Lanny RippleNext: Lanny Ripple
Message 15 of 21 in “Bug: rebase when an author uses accents in name on MacOSx”
  1. Lanny RippleMay 30, 2012
  2. Junio C HamanoMay 30, 2012
  3. Jürgen KreilederMay 30, 2012
  4. Jeff KingMay 31, 2012
  5. Junio C HamanoMay 31, 2012
  6. Lanny RippleMay 31, 2012
  7. Thomas RastMay 31, 2012
  8. Lanny RippleMay 31, 2012
  9. Junio C HamanoMay 31, 2012
  10. Lanny RippleMay 31, 2012
  11. Junio C HamanoMay 31, 2012
  12. Lanny RippleMay 31, 2012
  13. Jeff KingJun 1, 2012
  14. Lanny RippleJun 1, 2012
  15. Jeff KingJun 2, 2012
  16. Lanny RippleJun 2, 2012
  17. Junio C HamanoJun 1, 2012
  18. Lanny RippleJun 1, 2012
  19. Junio C HamanoJun 1, 2012
  20. Jeff KingJun 2, 2012
  21. Thomas RastMay 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.