git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove perl dependency from git-submodule.sh

From
Fredrik Gustafsson <iveqy@iveqy.com>
Date
May 31, 2012, 18:48 UTC
Message-ID
<20120531184841.GA32131@paksenarrion.iveqy.com>
In-Reply-To
<7vpq9k6y16.fsf@alter.siamese.dyndns.org>
On Thu, May 31, 2012 at 10:49:41AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> Having said that, in the longer term, I think the right direction to
> go is the opposite.  It would be better to make "git-submodule.sh"
> work better with paths with funny characters in them, and one
> obvious approach is to read "ls-files -z" output with something
> capable of parsing NUL-terminated records, e.g. a Perl scriptlet.
> Adding a new shell loop like this patch only adds one place that
> needs to be fixed later when that happens, so I am not sure I like
> this patch.

Is perl really a dependency that git wants? Today only a few bit (often non critical) are in perl. I thought the way was to get rid of those and replace them with c? I'm very critical to dependencies when they are not needed.

I don't think forking for text-parsing when not needed is a good idea either. Apart from the runtime issues, it makes the code harder to read.

With that said I do agree that funny path names should be supported and maybe the correct solution is to make more use of perl and less of sh. Mixing those, and doing it in the same file, I don't think is a good idea.

Is the right direction to run a shellscript that invokes a perl-scriptlet for textparsing?

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 9 in “Remove perl dependency from git-submodule.sh”
  1. Remove perl dependency from git-submodule.shFredrik Gustafsson, May 31, 2012
  2. Ævar Arnfjörð BjarmasonMay 31, 2012
  3. Fredrik GustafssonMay 31, 2012
  4. Johannes SixtMay 31, 2012
  5. Fredrik GustafssonMay 31, 2012
  6. Johannes SixtMay 31, 2012
  7. Junio C HamanoMay 31, 2012
  8. Fredrik GustafssonMay 31, 2012
  9. Junio C HamanoMay 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.