Re: git-completion with bash alias

From: Jeff King <peff@peff.net>
Date: May 19, 2012, 00:41 UTC
Message-ID: <20120519004147.GE765@sigill.intra.peff.net>
In-Reply-To: <CACY+Hvqd6L7gWgDBvjPmLPsfA2o1CVKuqkDZ_j7XYf=WjuwvKQ@mail.gmail.com>

On Fri, May 18, 2012 at 01:35:24PM +0200, Carsten Mattner wrote:

Show 6 quoted lines

> Completion works when used as "git checkout foo" but fails with
> "bash: [: 1: unary operator expected" when trying to complete
> via a single character shell alias like "alias g=git" as in
> "g checkout foo".
> 
> git version 1.7.10.2.548.g9de9681

Hmm. Are you invoking the completion like:

  complete -F _git g

? That used to work, but was broken by the recent 6b179ad (completion: add new __git_complete helper, 2012-05-14).

The "new" way seems to be:

  __git_complete g _git

but that function is explicitly labeled as "not public". It looks like there was a follow-on patch that was discussed to make a public version, but it got dropped.

I'm not sure if this regression is intentional, or if the "old" way even worked reliably (I seem to recall people running into issues with _get_comp_words_by_ref not being called properly sometimes, but I don't remember the details). So it's not clear to me if the right way forward is fixing "complete -F _git" to work again, or if that way is just broken, and a public version of __git_complete is the right path.

Felipe, can you comment?

-Peff