Re: [PATCH] correct git-status Porcelain Format documentation
- From
Jeff King <peff@peff.net>
- Date
- May 7, 2012, 18:13 UTC
- Message-ID
- <20120507181348.GA26977@sigill.intra.peff.net>
- In-Reply-To
- <7vobpz6ewg.fsf@alter.siamese.dyndns.org>
On Mon, May 07, 2012 at 11:10:23AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> Jeff King <peff@peff.net> writes: > > > What should "git status --porcelain -z -b" look like? With my patch, it > > prints the branch-line with only a newline, not respecting the NUL > > termination. Which sounds like a bug, except that's what happens _now_ > > with "git status --short -z -b". Which seems like a bug to me, but > > maybe somebody is relying on that. It seems kind of broken to me. > > It is broken; and it is not a problem if somebody relied on a broken > output without giving --porcelain in a script and such a script needs to > be updated. If we are updating the code to give "## <branch>" in the > output under the "--porcelain", let's do that right from the beginning.
OK, that matches my feelings.
Show 9 quoted lines
> > Should this be simplified to just "this implies porcelain"? > > > > That would technically break somebody who wanted their > > status.relativePaths config option respected. But it kind of seems crazy > > to me. > > I do not think it is worth changing it. It is not too much touble to > spell "status --porcelain -z <whatever else>" in a Porcelain script only > once and forget about it.
OK. I think it makes it conceptually simpler, but of the problems I listed, that is the least bug-like.
I'll prepare a series to fix "-b -z" and "-b --porcelain".
-Peff