Re: [PATCH/RFC] clone: inform the user we are checking out

From: Jeff King <peff@peff.net>
Date: May 7, 2012, 13:54 UTC
Message-ID: <20120507135446.GB4860@sigill.intra.peff.net>
In-Reply-To: <CABPQNSYe6dDf20D2pQpF=K97rZnWxqe5weEdO+FdKck9rwwzWg@mail.gmail.com>

On Mon, May 07, 2012 at 12:02:46PM +0200, Erik Faye-Lund wrote:

> OK, some blaming shows that this changed in 5bd631b3 ("clone: support
> multiple levels of verbosity"), back in February 2010. Before this
> patch, one would have to specify the "quiet"-flag to clone to suppress
> progress-output, after the patch the default is progress being off.

Yeah, I think this is a bug. We already show progress indicators from the transports without "-v", so there is no reason to require it for the checkout progress meter. And reading fbd631b3, it looks like the change is simply a mistake in the patch.

Show 17 quoted lines

> This seems like the right thing to do if we want to resurrect the
> progress-output's default-on behavior:
> ---8<---
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 3f863a1..f48e603 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -569,7 +569,7 @@ static int checkout(void)
>  	opts.update = 1;
>  	opts.merge = 1;
>  	opts.fn = oneway_merge;
> -	opts.verbose_update = (option_verbosity > 0);
> +	opts.verbose_update = (option_verbosity >= 0);
>  	opts.src_index = &the_index;
>  	opts.dst_index = &the_index;
> 
> ---8<---

Yes, that looks correct to me. Thanks for looking into this.

-Peff