Re: [PATCH 1/6] http: try http_proxy env var when http.proxy config option is not set

From: Jeff King <peff@peff.net>
Date: May 4, 2012, 16:05 UTC
Message-ID: <20120504160543.GB1331@sigill.intra.peff.net>
In-Reply-To: <7v4nrwc61e.fsf@alter.siamese.dyndns.org>

On Fri, May 04, 2012 at 08:36:13AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Thanks for a nice summary, and I agree with your list of what we wish we
> had from the cURL library.  With such a change, it becomes irrelevant how
> the user fed cURL provisional (partial) authentication information, either
> in http.proxy (which we turn into CURLOPT_PROXY), or from the environment
> (without Git having to know anything about it), and a lot of complexity
> that led to bugs in this series will become unnecessary.
> 
> I am tempted to suggest that the current series should be rerolled without
> all the guessing and preauth tricks until such an update to the cURL
> library materializes.

I am very tempted by that, too. In the meantime (and even once that curl version comes out and we write the new code, people will still be on the older version of curl), we have a fallback: they can use http.proxy if they want auth support. It's not as nice as supporting auth on the environment variables, but I think it will end up being a lot cleaner.

-Peff