git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: add tests for the bash prompt functions in the completion script

From
SZEDER Gábor <szeder@ira.uka.de>
Date
Apr 16, 2012, 10:20 UTC
Message-ID
<20120416102014.GF2900@goldbirke>
In-Reply-To
<CAMP44s0vkH9iE4MoV7HgGwOXna40pAL=h6be13qdreexp5_14w@mail.gmail.com>
On Mon, Apr 16, 2012 at 01:04:41PM +0300, Felipe Contreras wrote:
Show 15 quoted lines
> >> specially since there's the plan of splitting the prompt stuff to a
> >> separate file.
> >
> > Oh, I was not aware of such a plan.  What would be the benefits of
> > such a move, why is it necessary?  Where would you split it up?  In
> > particular, what would happen with __gitdir(), which is used in many
> > completion functions and in __git_ps1() as well?
> 
> I guess __gitdir() would be duplicated, I don't think that has been discussed.
> 
> http://thread.gmane.org/gmane.comp.version-control.git/194188
> 
> Basically splitting helps for systems that use bash-completion, and
> also helps for zsh users who don't want the bash completion, but still
> want __git_ps1(). I split the file myself for this reason.

Thanks for the pointer, those are valid reasons. I'll wait a day or two for feedback, then resubmit as a different test script.

Gábor
Previous: Felipe ContrerasNext: Jonathan Nieder
Message 5 of 14 in “tests: add tests for the bash prompt functions in the completion script”
  1. tests: add tests for the bash prompt functions in the completion scriptSZEDER Gábor, Apr 15, 2012
  2. Felipe ContrerasApr 15, 2012
  3. SZEDER GáborApr 16, 2012
  4. Felipe ContrerasApr 16, 2012
  5. SZEDER GáborApr 16, 2012
  6. Jonathan NiederApr 16, 2012
  7. 1/2 tests: move code to run completion tests under bash into a helper librarySZEDER Gábor, Apr 16, 2012
  8. 2/2 tests: add tests for the bash prompt functions in the completion scriptSZEDER Gábor, Apr 16, 2012
  9. Jonathan NiederApr 16, 2012
  10. SZEDER GáborApr 17, 2012
  11. Jonathan NiederApr 16, 2012
  12. SZEDER GáborApr 17, 2012
  13. Johannes SixtApr 17, 2012
  14. Felipe ContrerasApr 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.