Re: [PATCH] clean: add --null option

From: Clemens Buchacher <drizzd@aon.at>
Date: Apr 14, 2012, 19:38 UTC
Message-ID: <20120414193833.GA29999@ecki>
In-Reply-To: <1334426158-13607-1-git-send-email-rosslagerwall@gmail.com>

On Sat, Apr 14, 2012 at 07:55:58PM +0200, Ross Lagerwall wrote:

>
> Add a --null (-z) option to git-clean which prints out the files
> and directories separated with a NUL character rather than '\n'.
> This makes it useful in conjunction with xargs -0.

Thanks. Looks sensible to me.

> -					printf(_("Removing %s\n"), qname);
> +					print_path(_("Removing %s\n"), qname,
> +						   use_nul);

Although exceeding the 80 column boundary, I think this would be more readable without line break. If we want to stay within 80 columns, I don't think you can use 5 levels of indentation at the same time.

You could also make use_nul a static global, although it probably does not improve the situation much.