Re: [BUG] svn-fe: incorrect handling of files with newlines in them
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Apr 13, 2012, 22:22 UTC
- Message-ID
- <20120413222201.GA20197@burratino>
- In-Reply-To
- <4F88A502.9080207@pileofstuff.org>
(+cc: Ram) Hey,
Andrew Sayers wrote:
Show 5 quoted lines
> Note that I've used the intentionally provocative filename > $'readme.txt\nNode-kind: dir', but svn-fe doesn't fall for the trick. > The dump format doesn't escape the filename at all, so it would probably > fall for something cleverer like a 'copyfrom' line. To be honest I'm > not sure how you'd even detect such a filename.
Yep, sounds like a dump-load-format design bug.
> If the consensus is that this bug isn't fixable, I'd recommend putting a > note to that effect in "contrib/svn-fe/svn-fe.txt".
Makes sense. Please make it so.
Thanks much, Jonathan