git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: Only call a new ref a "branch" if it's under refs/heads/.

From
Jeff King <peff@peff.net>
Date
Apr 12, 2012, 21:05 UTC
Message-ID
<20120412210542.GD21018@sigill.intra.peff.net>
In-Reply-To
<4F873E2C.6080808@web.de>
On Thu, Apr 12, 2012 at 10:42:20PM +0200, Jens Lehmann wrote:
Show 8 quoted lines
> Am 12.04.2012 22:36, schrieb Marc Branchaud:
> > I assumed it was an optimization of some sort -- that since tags are normally
> > only fetched when they're part of a requested branch's history (right?),
> > there was no point in doing submodule recursion on the fetched tags since
> > those tagged tree-ishes had already been submodule-recursed.
> 
> If that is the case the patch I just sent is pointless, but adding a comment
> there explaining that would be a good thing ;-)

That is often the case, but not always (I might explicitly fetch a tag, or have refs/tags/ in my refspec). So I think you want to handle both to cover all cases. I haven't looked at the submodule recursion code, but I would hope that it would eliminate duplicates (so if I get a branch and a tag that is on the branch, we would look at the commit in question only once).

-Peff
Previous: Jens LehmannNext: Jeff King
Message 6 of 8 in “fetch: Only call a new ref a "branch" if it's under refs/heads/.”
  1. fetch: Only call a new ref a "branch" if it's under refs/heads/.marcnarc@xiplink.com, Apr 11, 2012
  2. Jeff KingApr 12, 2012
  3. Jens LehmannApr 12, 2012
  4. Marc BranchaudApr 12, 2012
  5. Jens LehmannApr 12, 2012
  6. Jeff KingApr 12, 2012
  7. Jeff KingApr 13, 2012
  8. submodules: recursive fetch also checks new tags for submodule commitsJens Lehmann, Apr 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.