git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC v2 0/4 resend] Re: fast-import: use struct hash_table

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 11, 2012, 12:12 UTC
Message-ID
<20120411121259.GB19568@burratino>
In-Reply-To
<1301572798-9973-1-git-send-email-david.barr@cordelta.com>

(resending with newer address for David. Sorry for the noise) Hi David,

David Barr wrote:
> The current custom hash tables in fast-import.c do not grow.
> This causes poor performance for very large imports.
> Fortunately, we have struct hash_table and friends so there's
> no need to write cumbersome hash table growth code.

Thanks for these patches. I've tentatively queued the following patches at

  git://repo.or.cz/git/jrn.git fast-import-pu
and would be happy to ask Junio to pull them if they look sane to you.
Sorry for the long delay.
David Barr (2):
  fast-import: allow object_table to grow dynamically
  fast-import: allow atom_table to grow dynamically
Jonathan Nieder (2):
  fast-import: allow branch_table to grow dynamically
  fast-import: use DIV_ROUND_UP
 fast-import.c |  153 ++++++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 102 insertions(+), 51 deletions(-)
Previous: Jonathan NiederNext: Jonathan Nieder
Message 9 of 13 in “fast-import: use struct hash_table”
  1. David BarrMar 31, 2011
  2. 1/2 fast-import: use struct hash_table for atom stringsDavid Barr, Mar 31, 2011
  3. Jonathan NiederApr 2, 2011
  4. Jonathan NiederApr 2, 2011
  5. 2/2 fast-import: use struct hash_table for objectsDavid Barr, Mar 31, 2011
  6. Jonathan NiederApr 2, 2011
  7. Jonathan NiederApr 2, 2011
  8. 0/4 Re: fast-import: use struct hash_tableJonathan Nieder, Apr 11, 2012
  9. 0/4 Re: fast-import: use struct hash_tableJonathan Nieder, Apr 11, 2012
  10. 1/4 fast-import: allow object_table to grow dynamicallyJonathan Nieder, Apr 11, 2012
  11. 2/4 fast-import: allow atom_table to grow dynamicallyJonathan Nieder, Apr 11, 2012
  12. 3/4 fast-import: allow branch_table to grow dynamicallyJonathan Nieder, Apr 11, 2012
  13. 4/4 fast-import: use DIV_ROUND_UPJonathan Nieder, Apr 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.