git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] var doc: default editor and pager are configurable at build time

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 31, 2012, 10:51 UTC
Message-ID
<20120331105106.GA12552@burratino>
In-Reply-To
<4f76de0e.2ac7b60a.54ce.ffffd85eSMTPIN_ADDED@mx.google.com>
Hi Rodrigo,
Rodrigo Silva wrote:
Show 11 quoted lines
>> Unfortunately those compile-time settings do not affect the
>> documentation, so the uninitiated user who tries to understand git by
>> reading the git-var(1) manpage can easily be confused when git falls
>> back to 'nano' and 'more' instead of 'vi' and 'less'.  Even if the
>> distributor patches the distributed docs to reflect the new default,
>> the user may read the official documentation from the git-htmldocs
>> repository online and be confused in the same way.
>
> I'm sorry, but I disagree with this approach. There is no "usually":
> upstream sources are *always* 'vi', and Debian packages are *always*
> 'editor'.

I disagree. If I build the pristine source from Junio with "./configure --with-shell=my-favorite-shell", I still have built the pristine source from Junio.

[...]
> Upstream git /could/ say "... and finally, a hardcoded editor chosen
> at compile time, by default 'vi'"
It is not hardcoded.
[...]
> IMHO, only saying that "it can be customized", "it is usually 'vi'",
> without saying it /was/ customized and it /isn't/ vi, but editor, is
> not a good approach.

Ah, perhaps that is the source of misunderstanding. This is a two-patch series. The two patches are meant to go together. Does that help?

Sorry for the lack of clarity, Jonathan

Previous: Junio C Hamano
Message 11 of 11 in “Re: [PATCH] Documentation: replace 'vi' for 'editor' to reflect build-time option”
  1. Jonathan NiederMar 30, 2012
  2. Junio C HamanoMar 30, 2012
  3. Bug#666250: [PATCH] Documentation: replace 'vi' for 'editor' to reflect build-time optionRodrigo Silva, Mar 30, 2012
  4. 0/2 Re: Documentation: replace 'vi' for 'editor' to reflect build-time optionJonathan Nieder, Mar 31, 2012
  5. 1/2 var doc: default editor and pager are configurable at build timeJonathan Nieder, Mar 31, 2012
  6. 2/2 var doc: advertise current DEFAULT_PAGER and DEFAULT_EDITOR settingsJonathan Nieder, Mar 31, 2012
  7. Junio C HamanoMar 31, 2012
  8. Jonathan NiederApr 18, 2012
  9. Phil HordMar 31, 2012
  10. Junio C HamanoMar 30, 2012
  11. Jonathan NiederMar 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.