Re: [PATCH] Add diff.minimal configuration setting

From: Jeff King <peff@peff.net>
Date: Mar 30, 2012, 08:09 UTC
Message-ID: <20120330080904.GA2661@sigill.intra.peff.net>
In-Reply-To: <20120329202648.GA27318@l0b0x>

On Thu, Mar 29, 2012 at 10:26:48PM +0200, Victor Engmark wrote:

> Complements the --minimal and --no-minimal options.

There was a recent discussion here:

  http://article.gmane.org/gmane.comp.version-control.git/192719

where two similar options were considered:

  1. diff.algorithm should be added, and consider "minimal" to be a
     variant algorithm

  2. we should have a generic "diff options" config variable, in which
     one could put "--minimal", "--patience", or whatever.

I don't think anything was decided, but either option would remove the need for a separate diff.minimal variable. Maybe it would be worth combining efforts.

-Peff

PS I like the generality of (2), but the idea of diff defaults came up a
   few years ago, and I remember it devolving into quite a complex
   patch. But that may also just have been the patch submitter, who
   seemed very interested in complexifying things. I can dig up the
   discussion if you want.