git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 3/3] gitweb: add If-Modified-Since handling to git_snapshot().

From
W. Trevor King <wking@drexel.edu>
Date
Mar 28, 2012, 19:27 UTC
Message-ID
<20120328192750.GA6909@odin.tremily.us>
In-Reply-To
<7vr4wcv8v4.fsf@alter.siamese.dyndns.org>
On Wed, Mar 28, 2012 at 12:11:27PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> "W. Trevor King" <wking@drexel.edu> writes:
> 
> > Grr.  Thanks.  I'm getting lots of rebase practice on this patch set,
> > but I'm still missing things…
> 
> How do you "rebase"?
> 
> It often is the easiest to check out the tip of the previous iteration,
> fix all issues that were brought up in the working tree, eyeball the
> output from "git diff HEAD" to make sure you addressed all the comments,o
> and then make separate commits, using "add -p" to sift the fix-ups
> according to which commit in the previous round they need to update.
> 
> And then finally you run "rebase -i" to squash these fix-ups in.

Ah, that makes a lot of sense. I had been running `rebase -i`, editing the earlier commits, and using `commit -a --amend` to squash them on. The problem with that approach is that you need to check the changes vs the previous release before each amend, while with your suggestion there's a single diff to look through.

Hopefully patches v8+ will be cleaner ;).
-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
Previous: Junio C HamanoNext: Jakub Narebski
Message 8 of 18 in “gitweb: refactor If-Modified-Since handling”
  1. 0/3 gitweb: refactor If-Modified-Since handlingW. Trevor King, Mar 28, 2012
  2. 1/3 gitweb: add `status` headers to git_feed() responses.W. Trevor King, Mar 28, 2012
  3. 2/3 gitweb: refactor If-Modified-Since handlingW. Trevor King, Mar 28, 2012
  4. 3/3 gitweb: add If-Modified-Since handling to git_snapshot().W. Trevor King, Mar 28, 2012
  5. Jakub NarebskiMar 28, 2012
  6. W. Trevor KingMar 28, 2012
  7. Junio C HamanoMar 28, 2012
  8. W. Trevor KingMar 28, 2012
  9. Jakub NarebskiMar 28, 2012
  10. Jakub NarebskiMar 28, 2012
  11. 0/3 gitweb: refactor If-Modified-Since handlingW. Trevor King, Mar 29, 2012
  12. Junio C HamanoMar 30, 2012
  13. 1/3 gitweb: add `status` headers to git_feed() responses.W. Trevor King, Mar 29, 2012
  14. Jakub NarebskiMar 30, 2012
  15. 2/3 gitweb: refactor If-Modified-Since handlingW. Trevor King, Mar 29, 2012
  16. Jakub NarebskiMar 30, 2012
  17. 3/3 gitweb: add If-Modified-Since handling to git_snapshot().W. Trevor King, Mar 29, 2012
  18. Jakub NarebskiMar 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.