Re: [PATCH] Demonstrate failure of 'core.ignorecase = true'

From: Jeff King <peff@peff.net>
Date: Mar 23, 2012, 18:57 UTC
Message-ID: <20120323185743.GA15063@sigill.intra.peff.net>
In-Reply-To: <20120323184823.GA14711@sigill.intra.peff.net>

On Fri, Mar 23, 2012 at 02:48:44PM -0400, Jeff King wrote:

Show 11 quoted lines

> I think Thomas's suggestion is to piggy-back it onto an existing file
> lookup ("head" instead of "HEAD"), so you aren't doing any extra work.
> However, I'm not sure that would be sufficient. If I copy a repo from a
> case-insensitive filesystem to a case-sensitive one, what will the case
> of "HEAD" be on the new filesystem?
> 
> If the original filesystem was case-preserving, I would expect "HEAD".
> But on a true caseless filesystem, it could be either. Of course,
> current git would already blow up if the file was copied as "head",
> which makes me think this is probably a rare case. So maybe that is not
> worth worrying about.

As soon as I sent this, I had two additional thoughts:

  1. You could probably just use "HeAd", which is unlikely to work
     anywhere except on a case-insensitive filesystem, and gets around
     my objection above.

  2. This still isn't a good test, because it is checking case
     sensitivity of the repo directory, not the working tree, and
     core.ignorecase is about the latter. It's possible to have the two
     on different filesystems with different capabilities.

     Though I think the initial test in "git init" suffers from the same
     problem (it checks that "config" is accessible as "CoNfIg"), and I
     have no heard anybody complaining about that.

-Peff