Re: [PATCH] git-am: error out when seeing -b/--binary
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 12, 2012, 21:56 UTC
- Message-ID
- <20120312215607.GB11362@burratino>
- In-Reply-To
- <87399dpk48.fsf@thomas.inf.ethz.ch>
Thomas Rast wrote:
> Ok, but if I don't get to say anything about repurposing, can I at least > make it an error message instead of just spewing out the "invalid > option" help?
I don't mind either way.
[...]
Show 10 quoted lines
> --- a/git-am.sh > +++ b/git-am.sh > @@ -380,7 +380,9 @@ do > -i|--interactive) > interactive=t ;; > -b|--binary) > - : ;; > + echo >&2 "The -b/--binary option was deprecated in 1.6.0 and removed in 1.7.10." > + die "Please adjust your scripts." > + ;;
Hm, on second thought, if people are seeing this message, I would prefer if they write to the mailing list so we can find out about it. So I really would rather see this say
--binary) : ;;
and have "-b" completely unrecognized, without any words in our defense except for a note in the release notes mentioning the option's removal and that it has been an unadvertised backward-compatibility no-op since 1.6.0.
Jonathan