Re: [PATCH v2 3/3] http: when proxy url has username but no password, ask for password

From: Jeff King <peff@peff.net>
Date: Mar 2, 2012, 13:52 UTC
Message-ID: <20120302135237.GB23846@sigill.intra.peff.net>
In-Reply-To: <4F50D39D.5040806@seap.minhap.es>

On Fri, Mar 02, 2012 at 03:05:17PM +0100, Nelson Benitez Leon wrote:

Show 7 quoted lines

> > I think you'll still need to read the env var, because you'll need to
> > know the proxy URL when getting the password (to ask credential helpers
> > properly, and to prompt the user).
> 
> Ok, but I can read it after receiving the 407 (and in case we were not
> using http.proxy) so discarding PATCH 2/3 still applies, ok? or we need
> to read it first-hand for the http_proactive_auth you mention below?

You will need it for proactive_auth.

Show 6 quoted lines

> > Also, I think you'll need to call credential_fill() when
> > http_proactive_auth is set. Otherwise http-push will not be able to do
> > proxy auth.
> 
> I still don't get what proactive_auth is about, will ask you when I get
> to that part of the patch.

It is a flag that, when true, instructs the http code to do auth if we have a non-NULL username, even before we get an http 401. It is only set for http-push, because the http-push-over-dav code does not properly detect and retry on a 401 (and I don't expect it will be easy to properly detect and retry on a 407, either). Whereas the smart-http code and the dumb http fetch code properly detect the 401.

-Peff