Re: [PATCH-w 101/105] t6300 (for-each-ref): modernize style
- From
Tom Grennan <tmgrennan@gmail.com>
- Date
- Mar 1, 2012, 15:48 UTC
- Message-ID
- <20120301154808.GG2572@tgrennan-laptop>
- In-Reply-To
- <87ty28n244.fsf@thomas.inf.ethz.ch>
On Thu, Mar 01, 2012 at 09:42:51AM +0100, Thomas Rast wrote:
Show 23 quoted lines
>Tom Grennan <tmgrennan@gmail.com> writes: >> On Wed, Feb 29, 2012 at 07:26:10PM -0800, Junio C Hamano wrote: >>>Tom Grennan <tmgrennan@gmail.com> writes: >>> >> Like I said, I think there is currently a debug distraction with verbose >> mode. However, rather than hiding expected failures and diverting other >> output as I had, perhaps we should dup stderr to stdout in verbose mode >> so error messages show up near the logged invocation when piped through >> a pager (i.e. mimic "|&"). With this, one can quickly scan past the >> noise to focus on the broken cases. > >If you have trouble finding the broken case, you can run with -v -i. > >I also think you are making an argument for a different feature (which >does not rob us of having all the debug output): test-lib.sh could >perhaps redirect the test output to a file, and dump the file to stdout >only if the test failed. Perhaps --verbose-failing or something like >that. > >Otherwise, your proposal is restricting us to having only an "easily >scannable" amount of output per test, perhaps 5-15 lines. Which I >personally think is an insane restriction for something that was >intended for debugging in the first place.
Oh, I hadn't tried -i with -v. This does mimic "|&". (cd t && ./t5512-ls-remote.sh -v -i) | less (cd t && ./t5512-ls-remote.sh -v) |& less
So, please ignore my suggestion.
Thanks, TomG