[PATCH v3] Documentation fixes in git-config
- From
- Libor Pechacek <lpechacek@suse.cz>
- Date
- Mar 1, 2012, 08:19 UTC
- Message-ID
- <20120301081941.GA31079@fm.suse.cz>
- In-Reply-To
- <20110121102537.GH19715@fm.suse.cz>
Variable names must start with an alphabetic character, regexp config key matching has its limits.
Signed-off-by: Libor Pechacek <lpechacek@suse.cz> Acked-by: Jeff King <peff@peff.net> ---
Hello Junio,
This patch has fallen through the cracks, therefore I re-send it. Previous discussion about this patch is at http://www.spinics.net/lists/git/msg149593.html. The only change I've done since version 2 of this patch is replacing apostrophes with backticks in the first hunk.
Be so kind as to apply the fix.
Libor
Documentation/config.txt | 12 +++++++----- Documentation/git-config.txt | 9 +++++++-- 2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt index e55dae1..078313e 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -12,8 +12,9 @@ The configuration variables are used by both the git plumbing and the porcelains. The variables are divided into sections, wherein the fully qualified variable name of the variable itself is the last dot-separated segment and the section name is everything before the last -dot. The variable names are case-insensitive and only alphanumeric -characters are allowed. Some variables may appear multiple times. +dot. The variable names are case-insensitive, allow only alphanumeric +characters and `-`, and must start with an alphabetic character. Some +variables may appear multiple times. Syntax ~~~~~~ @@ -54,9 +55,10 @@ All the other lines (and the remainder of the line after the section header) are recognized as setting variables, in the form 'name = value'. If there is no equal sign on the line, the entire line is taken as 'name' and the variable is recognized as boolean "true". -The variable names are case-insensitive and only alphanumeric -characters and `-` are allowed. There can be more than one value -for a given variable; we say then that variable is multivalued. +The variable names are case-insensitive, allow only alphanumeric characters +and `-`, and must start with an alphabetic character. There can be more +than one value for a given variable; we say then that variable is +multivalued. Leading and trailing whitespace in a variable value is discarded. Internal whitespace within a variable value is retained verbatim. diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index aa8303b..a54fee8 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt @@ -85,8 +85,13 @@ OPTIONS is not exactly one. --get-regexp:: - Like --get-all, but interprets the name as a regular expression. - Also outputs the key names. + Like --get-all, but interprets the name as a regular expression and + writes out the key names. Regular expression matching is currently + case-sensitive and done against a canonicalized version of the key + in which section and variable names are lowercased, but subsection + names are not. Regular expressions are partially lower-cased + before matching (everything before the first dot and after the last + dot), which makes things like "Core.*' work. --global:: For writing options: write to global ~/.gitconfig file rather than
-- 1.7.9.2.324.g78dedf