Re: [PATCH 2/2] bundle: use a strbuf to scan the log for boundary commits

From: Jeff King <peff@peff.net>
Date: Feb 22, 2012, 21:00 UTC
Message-ID: <20120222210000.GE6781@sigill.intra.peff.net>
In-Reply-To: <87hayivcmm.fsf@thomas.inf.ethz.ch>

On Wed, Feb 22, 2012 at 09:25:53PM +0100, Thomas Rast wrote:

Show 12 quoted lines

> > Thanks for diagnosing this, but I wonder if it even needs --pretty=oneline
> > to begin with, except for debugging purposes.
> >
> > Do we ever use the subject string read from the rev-list output in any
> > way?
> >
> > In other words, I am wondering if the right patch to minimally fix the
> > issue starting from older releases is something along this line instead:
> 
> Not sure.  The only use I could think of would be to google for the
> subjects, in the hope of finding some repository that has the commit you
> are looking for.  Other than that...

Or because the bundle creator (which may even be you on a different day) did not correctly guess at the negative refs when specifying a cutoff. Assuming you no longer have access to the original repo (not unreasonable, since you are using a bundle), the messages could help you understand where the error occurred.

Of course, once you figure out "aha! I expected the bundle to include foo, but it is actually a cutoff point. I should have said XYZ^ as the cutoff", I'm not sure what you do then. It's not like there is an easy way to salvage the data that is in the bundle.

So I think it is a debugging aid, but one that ultimately doesn't help you that much.

-Peff