Re: [PATCH] builtin/tag.c: Fix a sparse warning
On Mon, Feb 13, 2012 at 06:24:41PM +0000, Ramsay Jones wrote:
Show 12 quoted lines
>
>In particular, sparse complains as follows:
>
> SP builtin/tag.c
> builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \
> not declared. Should it be static?
>
>In order to suppress the warning, since the parse_opt_points_at()
>function does not need to be an external symbol, we simply add the
>static modifier to the function definition.
>
>Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Acked-by: Tom Grennan <tmgrennan@gmail.com>
Thanks
Show 22 quoted lines
>---
>
> builtin/tag.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/builtin/tag.c b/builtin/tag.c
>index 8cfaaf8..fe7e5e5 100644
>--- a/builtin/tag.c
>+++ b/builtin/tag.c
>@@ -408,7 +408,7 @@ static int strbuf_check_tag_ref(struct strbuf *sb, const char *name)
> return check_refname_format(sb->buf, 0);
> }
>
>-int parse_opt_points_at(const struct option *opt __attribute__ ((unused)),
>+static int parse_opt_points_at(const struct option *opt __attribute__((unused)),
> const char *arg, int unset)
> {
> unsigned char sha1[20];
>--
>1.7.9
>
>Tom Grennan <tmgrennan@gmail.com>