Re: [PATCHv2] tag: add --points-at list option
- From
Jeff King <peff@peff.net>
- Date
- Feb 7, 2012, 19:36 UTC
- Message-ID
- <20120207193632.GC32367@sigill.intra.peff.net>
- In-Reply-To
- <20120207192135.GC6264@tgrennan-laptop>
On Tue, Feb 07, 2012 at 11:22:50AM -0800, Tom Grennan wrote:
Show 19 quoted lines
> >> Thanks, but I now realize that I also need to save the pointed at > >> refname to detect lightweight tags that have matching sha's but > >> different names. > > > >I'm not sure I understand. Wouldn't you match lightweight tags by the > >sha1 they point at? Something like: > > I think the following would show the pointed at tag too. > $ git tag my-v1.7.9 v1.7.9 > $ ./git-tag -l --points-at v1.7.9 > my-v1.7.9 > v1.7.9 > > vs. > > $ ./git-tag -l --points-at v1.7.9 > my-v1.7.9 > > I found that I had to filter matching refnames.
Ah, so you are trying _not_ to show lightweight tags (I thought you meant you also wanted to show them)? But I still don't see why the code I posted before wouldn't work in that case. The "object" field of v1.7.9 is not the sha1 of the v1.7.9 tag object, but rather some commit, so it would not match.
Maybe I don't understand what you mean. Can you show a test case that is buggy with the v2 version of the patch that you sent? I'm not sure in the example above what is different between the two "git-tag" invocations.
-Peff