Re: [PATCH 2/4] commit: introduce a config key to allow as-is commit with i-t-a entries
Nguyen Thai Ngoc Duy wrote:
> 2012/2/7 Junio C Hamano <gitster@pobox.com>:
Show 13 quoted lines
>>> + if (i < active_nr)
>>> + warning(_("You are committing as-is with intent-to-add entries as the result of\n"
>>> + "\"git add -N\". Git currently forbids this case.
>>
>> Can we phrase this a bit better?
>>
>> It is not like "forbids", but is "giving up because you didn't tell me
>> what content to include in the commit, even though you said you will tell
>> me later".
>
> "rejects"? I would rather say "see `git add -N` man page for more
> explanation" than putting it here. The warning is quite long as it is
> right now.If I ruled the world, it would say something like this:
error: you intended to add "foo.c" but did not add it; not committing
hint: to commit all changes to tracked files, use "commit -a"
hint: to commit without adding "foo.c", use "commit --ignore-intent-to-add", which may become the default in future versions of git
But without the long line. ;-)
Jonathan Nieder <jrnieder@gmail.com>