Re: [PATCH] Fix an "variable might be used uninitialized" gcc warning

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 31, 2012, 19:43 UTC
Message-ID: <20120131194302.GD12443@burratino>
In-Reply-To: <4F2834AD.20004@ramsay1.demon.co.uk>

Ramsay Jones wrote:

Show 6 quoted lines

> The versions which complain are 3.4.4 and 4.1.2, whereas 4.4.0 compiles
> the code without complaint. So, gcc *may* be getting more sane, but I wouldn't
> bet on it! :-P
>
> I've had examples of this kind of warning, which relies heavily on the
> analysis performed primarily for the optimizer, come-and-go in gcc before

Yep, judging from the commit message, Junio found the same warning in 4.6.2.

[...]

> Having said that, unless you are going to decree that the project only
> supports gcc (and presumably only some particular versions of gcc), then you
> may well find similar warnings triggered when using other compilers anyway ...

Sure, when the control flow grows too complicated, that's probably worth fixing anyway, for the sake of humans especially.

Sometimes gcc is the only crazy one, though. ;-)

Thanks for the update. Jonathan