Re: [PATCH v2 2/2] tree_entry_interesting: make recursive mode default

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jan 18, 2012, 08:59 UTC
Message-ID: <20120118085951.GA704@duynguyen-vnpc.dek-tpc.internal>
In-Reply-To: <7v1uqzwaxs.fsf@alter.siamese.dyndns.org>

On Mon, Jan 16, 2012 at 02:15:59PM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> Yeah, the logic of this correction is very clear. Because diff_cache is
> about walking a flat index, the "recursive pathspec" that allows us to
> look into deeper levels in directory hierarchy should be set, and also we
> should not be limiting the depth of the match in any way by setting the
> max_depth to "unlimited".

For the record, enabling wildcard in git-log is just as simple. But I guess you don't want more changes this late in rc cycles.

-- 8< --

diff --git a/revision.c b/revision.c
index 064e351..c426271 100644
--- a/revision.c
+++ b/revision.c
@@ -1816,6 +1816,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
 
 	if (revs->prune_data.nr) {
 		diff_tree_setup_paths(revs->prune_data.raw, &revs->pruning);
+		revs->pruning.pathspec.recursive = 1;
+		revs->pruning.pathspec.max_depth = -1;
 		/* Can't prune commits with rename following: the paths change.. */
 		if (!DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
 			revs->prune = 1;
-- 8< --

--
Duy