Re: [PATCH 2/2] commit, write-tree: allow to ignore CE_INTENT_TO_ADD while writing trees
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jan 17, 2012, 02:47 UTC
- Message-ID
- <20120117024720.GA32602@burratino>
- In-Reply-To
- <CACsJy8B_qGphVz8PFhPNLsOe-Ve7xb+biNP8Ok7dXiygu3KoSg@mail.gmail.com>
Nguyen Thai Ngoc Duy wrote:
> Although I would not oppose deprecating the old behavior if you go with (2) ;)
My reaction on reading the patch and clarifying followup was similar to Junio's. I don't think a configuration item makes sense unless we are planning to flip the default in the future, and it would probably be clearer to document it that way.
By the way, thanks very much for working on this. I wish I had more time to offer more than comments.
Sincerely, Jonathan