git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: thin packs ending up fat

From
Jeff King <peff@peff.net>
Date
Jan 13, 2012, 15:15 UTC
Message-ID
<20120113151545.GA9373@sigill.intra.peff.net>
In-Reply-To
<7vmx9sysqe.fsf@alter.siamese.dyndns.org>
On Thu, Jan 12, 2012 at 11:19:37PM -0800, Junio C Hamano wrote:
> I wanted to make sure I understood the root cause of the issue and the
> approach the patch takes to address it, instead of committing something
> that smelled correct. And the only way I know to do so is to write it
> down.
I use something of the same technique myself...
Show 8 quoted lines
> Especiallly, before coming up with the description, I was wondering if
> this kind of symptom appears in non-thin cases, but after writing down the
> justification for this patch, it became clear that we wouldn't have to
> worry too much about that case. In a non-thin pack, we need to record one
> object at least in a delta family in inflated base form, so we may as well
> send that one near the tip that is already in that form for that, letting
> the existing "avoid futile delta" heuristics to kick in. Other objects in
> the same delta family will delta against it.

Exactly. You asked earlier why my one-liner patch was not in the first message. It's because it was only through writing the first message that I came to the same realization. :)

-Peff
Previous: Junio C HamanoNext: Nicolas Pitre
Message 9 of 12 in “thin packs ending up fat”
  1. Jeff KingJan 12, 2012
  2. Jeff KingJan 12, 2012
  3. Nicolas PitreJan 12, 2012
  4. Junio C HamanoJan 13, 2012
  5. Junio C HamanoJan 13, 2012
  6. Jeff KingJan 13, 2012
  7. Jeff KingJan 13, 2012
  8. Junio C HamanoJan 13, 2012
  9. Jeff KingJan 13, 2012
  10. Nicolas PitreJan 13, 2012
  11. Ævar Arnfjörð BjarmasonJan 13, 2012
  12. Jeff KingJan 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.