git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] expanded hook api with stdio support

From
Jeff King <peff@peff.net>
Date
Jan 3, 2012, 20:06 UTC
Message-ID
<20120103200642.GH20926@sigill.intra.peff.net>
In-Reply-To
<7vsjjwtvf1.fsf@alter.siamese.dyndns.org>
On Tue, Jan 03, 2012 at 11:53:22AM -0800, Junio C Hamano wrote:
Show 12 quoted lines
> Johannes Sixt <j6t@kdbg.org> writes:
> 
> > IMO, as the first step, the user of this infrastructure should only be
> > required to construct the hook input as a strbuf, and receive the hook
> > output, if needed, also as a strbuf.
> 
> Now you brought it up, I think I would agree. The only reason I suggested
> a callback feeder approach was because I somehow was hoping that it may be
> possible to share more code with the codepath for textconv that may not
> want to hold too much buffer in core when we know the data is only used
> sequencially and I wanted to see more things to go through streaming API
> in the future.

Even if we don't make the input streaming, it would be nice to factor the concept of "feed input to program and read its output without deadlocking" into something independent of hooks.

The credential helper code could potentially have the same deadlock. Possibly also clean/smudge filters.

Maybe it could even be part of the run-command interface?
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 10 in “extended hook api and tweak-fetch hook”
  1. Joey HessDec 30, 2011
  2. 1/3 expanded hook api with stdio supportJoey Hess, Dec 30, 2011
  3. Johannes SixtDec 30, 2011
  4. Joey HessDec 30, 2011
  5. Johannes SixtDec 30, 2011
  6. Junio C HamanoJan 3, 2012
  7. Jeff KingJan 3, 2012
  8. Junio C HamanoJan 3, 2012
  9. 2/3 preparations for tweak-fetch hookJoey Hess, Dec 30, 2011
  10. 3/3 add tweak-fetch hookJoey Hess, Dec 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.