Re: [PATCH] make "git push -v" actually verbose

From: Jeff King <peff@peff.net>
Date: Dec 17, 2011, 19:50 UTC
Message-ID: <20111217195024.GA32441@sigill.intra.peff.net>
In-Reply-To: <7vobv7dmak.fsf@alter.siamese.dyndns.org>

On Sat, Dec 17, 2011 at 11:34:59AM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> > One minor clarification: it is not technically true that "git push -v"
> > does nothing. It just does not do the interesting "show a verbose status
> > table" operation, which is almost certainly what the user wants (and
> > what happened before the commits I mentioned). It does print "Pushing to
> > $url", since that happens above the transport layer. But I'm pretty sure
> > that is not what users of "-v" are interested in. :)
> 
> Thanks, but don't be so sure about that.
> 
> When you are so used to say "git push ko", from time to time you want to
> check which one of your kernel.org machine you are pushing into; that
> "pushing to this exact url" is actually quite useful.

But we will also print that as part of the status table, so it really is redundant. The only difference is that it comes before the object transfer phase, so if the whole thing barfs before you even make it to the status table, you get a little more debugging output (although typically the URL is mentioned in the die() message, anyway).

E.g.:

  $ git push github
  Counting objects: 214, done.
  Compressing objects: 100% (131/131), done.
  Writing objects: 100% (135/135), 33.73 KiB, done.
  Total 135 (delta 102), reused 9 (delta 4)
  To https://github.com/peff/git.git
   + 710a44a...0fa8107 private -> private (forced update)

Before my patch, adding "-v" would just put the "Pushing to https://..." before the object phase.

Anyway, regardless of the utility of that message, I think the fix makes sense. It really looks like an unintended regression in 8afd8dc, and certainly the original intent of the code was to match fetch's use of "-v" to show up-to-date entries in the status table (which I know because I wrote it).

-Peff