tr/pty-all (Re: What's cooking in git.git (Dec 2011, #04; Tue, 13))

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 14, 2011, 07:09 UTC
Message-ID: <20111214070916.GA14954@elie.hsd1.il.comcast.net>
In-Reply-To: <7vobvcrlve.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 6 quoted lines

> * tr/pty-all (2011-12-12) 3 commits
>  - t/lib-terminal: test test-terminal's sanity
>  - test-terminal: set output terminals to raw mode
>  - test-terminal: give the child an empty stdin TTY
>
> Will merge to 'next' after taking another look.

The middle commit looks good. The bottom commit could be improved as discussed at [1], but I guess that can happen in-tree.

However, the top commit ("test test-terminal's sanity") still does not seem right to me.

It makes the same test run three times. Probably I should send an alternate patch to get that sanity-check to run once, but I am also not convinced the sanity-check is needed at all --- wouldn't any test that is relying on output from test_terminal act as a sanity check for it already?

As an aside, I also still believe that running "git shortlog" without explicitly passing "HEAD" when testing how it reacts to [core] pager configuration was a bug and a distraction, hence the patch at [2]. Am I the only one? I also find Jeff's patch [3] appealing.

Thanks, Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/186923/focus=186944 [2] http://article.gmane.org/gmane.comp.version-control.git/186932 [3] http://article.gmane.org/gmane.comp.version-control.git/186936