git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t5540: test DAV push with authentication

From
Jeff King <peff@peff.net>
Date
Dec 13, 2011, 23:16 UTC
Message-ID
<20111213231630.GB12432@sigill.intra.peff.net>
In-Reply-To
<CAHGBnuO1CFGacMQb+Md_uGsLu=V9bGDpcFLd9Lb4C5jSN+uUiw@mail.gmail.com>
On Tue, Dec 13, 2011 at 10:28:07PM +0100, Sebastian Schuberth wrote:
Show 8 quoted lines
> On Tue, Dec 13, 2011 at 21:17, Jeff King <peff@peff.net> wrote:
> 
> > We don't currently test this case at all, and instead just
> > test the DAV mechanism over an unauthenticated push. That
> > isn't very realistic, as most people will want to
> > authenticate pushes.
> 
> Thanks for adding this, Peff!

You're welcome. Thank you for forwarding the bug report. I would never have seen it on the msysgit list, and for some reason it seems that msysgit people are more likely to use DAV.

Having looked a lot at the http code the past month or two, I knew it was pretty flaky and I was nervous when we added Stefan's patch (and no, I don't blame Stefan; his patch was completely reasonable, but just happened to trigger a problem in a seldom-looked-at corner of the code).

But I hadn't looked at http-push at all until yesterday, and it didn't even occur to me that there was another whole area of code relying in a very obscure way on the http.c auth code. I'll take a look at some of the refactoring I've done in http.c (both for the credentials topic as well as the bundle topic) and see if we can't integrate http-push.c a little more smoothly.

-Peff
Previous: Sebastian Schuberth
Message 14 of 14 in “t5540: test DAV push with authentication”
  1. 1/2 t5540: test DAV push with authenticationJeff King, Dec 13, 2011
  2. Revert "http: don't always prompt for password"Jeff King, Dec 13, 2011
  3. Junio C HamanoDec 13, 2011
  4. Eric AdvinculaDec 13, 2011
  5. Jeff KingDec 13, 2011
  6. Jeff KingDec 13, 2011
  7. Jeff KingDec 13, 2011
  8. Jeff KingDec 14, 2011
  9. Junio C HamanoDec 14, 2011
  10. Matthieu MoyDec 14, 2011
  11. Junio C HamanoDec 13, 2011
  12. Jeff KingDec 13, 2011
  13. Sebastian SchuberthDec 13, 2011
  14. Jeff KingDec 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.