git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 2/2] change all unchecked calls to setenv to xsetenv

From
Jeff King <peff@peff.net>
Date
Dec 13, 2011, 18:19 UTC
Message-ID
<20111213181946.GC1663@sigill.intra.peff.net>
In-Reply-To
<1323778227-1664-2-git-send-email-kusmabite@gmail.com>
On Tue, Dec 13, 2011 at 01:10:27PM +0100, Erik Faye-Lund wrote:
Show 11 quoted lines
> While reviewing some patches for Git for Windows, I realized that
> we almost never check the return-value from setenv. This can lead
> to quite surprising errors in unusual sitations. Mostly, an error
> would probably be preferred. So here we go.
> 
> However, I'm not at all convinced myself that all of these make
> sense; in particular settings like GIT_EDITOR and GIT_PAGER could
> perhaps benefit from having a warning printed rather than a hard
> error.
> 
> Thoughts?

I wrote almost the same patch once[1], but failed to actually push it through to acceptance. There weren't any objections, just that nobody really cared. I think it's a reasonable thing to do. The chances of setenv failing are very low, but the consequences could be quite bad.

There is also a call to putenv in git.c which should be checked (or could arguably just be converted to setenv).

-Peff
[1] http://thread.gmane.org/gmane.comp.version-control.git/134466
Previous: Erik Faye-LundNext: Junio C Hamano
Message 3 of 9 in “wrapper: supply xsetenv”
  1. 1/2 wrapper: supply xsetenvErik Faye-Lund, Dec 13, 2011
  2. 2/2 change all unchecked calls to setenv to xsetenvErik Faye-Lund, Dec 13, 2011
  3. Jeff KingDec 13, 2011
  4. Junio C HamanoDec 13, 2011
  5. Erik Faye-LundDec 13, 2011
  6. Jeff KingDec 13, 2011
  7. Junio C HamanoDec 13, 2011
  8. Erik Faye-LundDec 13, 2011
  9. Andreas SchwabDec 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.