Re: [PATCH 1/3] test-terminal: give the child an empty stdin TTY

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 12, 2011, 23:25 UTC
Message-ID: <20111212232503.GA12366@elie.hsd1.il.comcast.net>
In-Reply-To: <20111212191602.GA14061@sigill.intra.peff.net>

Jeff King wrote:

Show 12 quoted lines

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -198,6 +198,9 @@ else
>  	exec 4>/dev/null 3>/dev/null
>  fi
>
> +exec 6<&0
> +exec 0</dev/null
> +
>  test_failure=0
>  test_count=0
>  test_fixed=0

Independently of the changes to explicitly pass HEAD to "git shortlog" in t7006 (we should) and make test_terminal make stdin into a tty, too (if tests still make sure "git log --stdin" launches a pager with stdin not a tty, then it should be a fine change), this looks good to me.