Re: Breakage (?) in configure and git_vsnprintf()

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 12, 2011, 21:56 UTC
Message-ID: <20111212215645.GA3024@elie.hsd1.il.comcast.net>
In-Reply-To: <20111212064305.GA16511@sigill.intra.peff.net>

Jeff King wrote:

Show 7 quoted lines

> I'll leave the issue of "-std=c89" triggering SNPRINTF_RETURNS_BOGUS to
> people who know and care about autoconf. My gut is to say "don't do
> that". Git is not actually pure c89. We typically target systems that
> are _at least_ c89, but it's more important to match and run well on
> real-world systems than what was defined in the standard. So we don't
> depend on c99, but we do depend on quirks and features that were
> prominent in mid-90's Unix variants.

Using vsnprintf isn't even wrong from the standards-pedant point of view --- vsnprintf has been in POSIX for a long time. The problem is that the configure script is not setting appropriate feature test macros such as _XOPEN_SOURCE (like git-compat-util.h does) during its feature tests.

Maybe it would be possible to hook the appropriate magic into AC_LANG_PROGRAM.