Re: [PATCHv3 08/13] credential: make relevance of http path configurable
- From
Jeff King <peff@peff.net>
- Date
- Dec 10, 2011, 19:50 UTC
- Message-ID
- <20111210195033.GB17999@sigill.intra.peff.net>
- In-Reply-To
- <m3mxb0hcjs.fsf@localhost.localdomain>
On Sat, Dec 10, 2011 at 03:50:11AM -0800, Jakub Narebski wrote:
Show 16 quoted lines
> > This is nothing you couldn't do with a clever credential
> > helper at the start of your stack, like:
> >
> > [credential "http://"]
> > helper = "!f() { grep -v ^path= ; }; f"
> > helper = your_real_helper
> >
> > But doing this:
> >
> > [credential]
> > useHttpPath = false
>
> Shouldn't this be 'usePath' or 'usePathComponent' or 'useRepositoryPath',
> etc.? Because if^W when remote helper for Subversion is complete, you
> could have svn://svnserve.example.com/path/to/repo as an URL... which
> would be not HTTP(S).It must be per-protocol, because paths will be relevant for some protocols (e.g., unlocking certificates in the local filesystem). So if anything, it would be "useNetworkPath" or something, if we wanted to unify svn and http. But it would also be OK to have a separate flag for http and svn, which is more flexible (and most users aren't going to set it at all, so they won't notice).
-Peff