Re: [PATCH 2/2] t3401: use test_commit in setup
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Dec 9, 2011, 19:57 UTC
- Message-ID
- <20111209195752.GA21260@elie.hsd1.il.comcast.net>
- In-Reply-To
- <CALkWK0k-dL3xZ+dyqdACj7man-Q2QrAPZCCMhXiX0WNGZHv6Fw@mail.gmail.com>
Ramkumar Ramachandra wrote:
> Martin von Zweigbergk wrote:
Show 8 quoted lines
>> Simplify t3401 by using test_commit in the setup. This lets us refer >> to commits using their tags and there is no longer a need to create >> the branch my-topic-branch-merge. Also, the branch master-merge points >> to the same commit as master (even before this change), so that branch >> does not need to be created either. > > The terms "tag" and "branch" here have no significance, so > de-emphasizing them to "ref" is probably a good idea.
Wha? No, "tag" refers to refs under refs/tags/, and "branch" refers to refs/heads/, just like usual.
I like the patch, for what it's worth.