git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/7] add generic terminal prompt function

From
Jeff King <peff@peff.net>
Date
Dec 8, 2011, 21:52 UTC
Message-ID
<20111208215218.GA12127@sigill.intra.peff.net>
In-Reply-To
<m38vmmivkc.fsf@localhost.localdomain>
On Thu, Dec 08, 2011 at 01:48:33PM -0800, Jakub Narebski wrote:
Show 11 quoted lines
> > @@ -833,6 +838,7 @@ ifeq ($(uname_S),Linux)
> >  	NO_STRLCPY = YesPlease
> >  	NO_MKSTEMPS = YesPlease
> >  	HAVE_PATHS_H = YesPlease
> > +	HAVE_DEV_TTY = YesPlease
> >  endif
> 
> Here you use HAVE_DEV_TTY (by the way, I wonder if it could be
> automatically detected by ./configure script)...
> [...]
> ...and here you have NO_DEV_TTY

Whoops. Thanks for catching. I converted it to NO_DEV_TTY, which would turn this code on by default (because I think _most_ platforms we use are going to want this), but then I decided to go the conservative route and let platforms opt into it.

And of course since my platform is the one that enables it, I didn't notice during my testing.

I'll fix it for the next re-roll.
-Peff
Previous: Jakub NarebskiNext: Jeff King
Message 9 of 11 in “[PATCHv2 0/7] getpass refactoring”
  1. Jeff KingDec 8, 2011
  2. 1/7 imap-send: avoid buffer overflowJeff King, Dec 8, 2011
  3. 2/7 imap-send: don't check return value of git_getpassJeff King, Dec 8, 2011
  4. 3/7 move git_getpass to its own source fileJeff King, Dec 8, 2011
  5. 4/7 refactor git_getpass into generic prompt functionJeff King, Dec 8, 2011
  6. Junio C HamanoDec 9, 2011
  7. 5/7 add generic terminal prompt functionJeff King, Dec 8, 2011
  8. Jakub NarebskiDec 8, 2011
  9. Jeff KingDec 8, 2011
  10. 6/7 prompt: use git_terminal_promptJeff King, Dec 8, 2011
  11. 7/7 credential: use git_prompt instead of git_getpassJeff King, Dec 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.