Re: [PATCH] userdiff: allow * between cpp funcname words

From: Jeff King <peff@peff.net>
Date: Dec 6, 2011, 20:19 UTC
Message-ID: <20111206201944.GB27930@sigill.intra.peff.net>
In-Reply-To: <201112062117.57690.trast@student.ethz.ch>

On Tue, Dec 06, 2011 at 09:17:56PM +0100, Thomas Rast wrote:

Show 15 quoted lines

> > Looks reasonable to me. You can see the difference, for instance, with:
> > 
> >   git show -U1 3c73a1d
> > 
> > (The -U1 is because of the annoying "we will start looking for the
> > header at the top of context, not the top of changes" behavior I
> > mentioned last week).
> 
> Actually (sadly) I'll have to revise it.  It doesn't match much of C++
> either, and I haven't yet come up with a reasonable regex that
> matches, say,
> 
>   foo::Bar<int>::t& Baz::operator<<(
> 
> which I would call ludicrous, but it's valid C++.

Ick, yeah. Maybe it is worth doing the "*" thing for now, and then worrying about advanced C++ stuff on top as another patch. AFAICT, your original patch is a strict improvement.

-Peff