Re: git auto-repack is broken...
- From
Jeff King <peff@peff.net>
- Date
- Dec 2, 2011, 18:13 UTC
- Message-ID
- <20111202181358.GD24093@sigill.intra.peff.net>
- In-Reply-To
- <7vd3c6onhs.fsf@alter.siamese.dyndns.org>
On Fri, Dec 02, 2011 at 10:08:15AM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> Jeff King <peff@peff.net> writes: > > > But we shouldn't be packing totally unreferenced objects. > > Everything you said is correct in today's Git and I obviously know it, but > I was taking the "Or have an extra option to..." at the end of the OP's > message in the thread into account, so...
Ah, sorry, I missed the subtlety of Linus's "repacking the objects results in problems..." from his later message and thought he just meant repacking in general. Yes, it's a bad idea to repack unreachable objects because then you could never prune anything.
I think just shrinking the --expire window that we already use is a much more reasonable bet. It's not about preventing the loss of old work (reflogs are there for that), but about avoiding hurting an actively running, about-to-reference-the-objects git process. And 2 weeks is quite conservative for that.
-Peff